Hello Jessica, On Tue, Dec 10, 2024 at 09:45:09AM -0800, Jessica Zhang wrote: > [...] > > +static const struct raydium_rm67200_panel_info w552793baa_info = { > > + .mode = { > > + .clock = 132000, > > + .hdisplay = 1080, > > + .hsync_start = 1095, > > + .hsync_end = 1125, > > + .htotal = 1129, > > + .vdisplay = 1920, > > + .vsync_start = 1935, > > + .vsync_end = 1950, > > + .vtotal = 1952, > > + .width_mm = 68, /* 68.04mm */ > > + .height_mm = 121, /* 120.96mm */ > > + .type = DRM_MODE_TYPE_DRIVER, > > + }, > > + .regulators = w552793baa_regulators, > > + .num_regulators = ARRAY_SIZE(w552793baa_regulators), > > + .panel_setup = w552793baa_setup, > > Just curious, will there be other panels with different regulators and init > commands added for this driver in the future? I don't know any other RM67200 based panels. But the init sequence contains lots of vendor specific registers and I'm pretty sure it is specific to the W552793BAA. I put the regulators into the panel specific section, because the datasheet for the RM67200 specifies slightly different ones than the w552793baa datasheet. Thus I expect that other displays might have slight differences. Greetings, -- Sebastian
Attachment:
signature.asc
Description: PGP signature