Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

[Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>]

Hi,

On 10/12/2024 18:34, Geert Uytterhoeven wrote:
> Hi Tomi,
>
> On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen
> <tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:
> > From: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> >
> > Add support for the mini DP output on the Gray Hawk board.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dts
> > @@ -269,6 +314,51 @@ eeprom@53 {
> >          };
> >   };
> >
> > +&i2c1 {
> > +       pinctrl-0 = <&i2c1_pins>;
> > +       pinctrl-names = "default";
> > +
> > +       status = "okay";
> > +       clock-frequency = <400000>;
> > +
> > +       bridge@2c {
>
> Missing:
>
>          pinctrl-0 = <&irq0_pins>;
>          pinctrl-names = "default";
>
> > +               compatible = "ti,sn65dsi86";
> > +               reg = <0x2c>;
> > +
> > +               clocks = <&sn65dsi86_refclk>;
> > +               clock-names = "refclk";
> > +
> > +               interrupt-parent = <&intc_ex>;
> > +               interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
>
> interrupts-extended = ...

Is that just to use the same style in the whole dts, or is there some 
specific need for the extended one here?

> > +
> > +               enable-gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> > +
> > +               vccio-supply = <&reg_1p8v>;
> > +               vpll-supply = <&reg_1p8v>;
> > +               vcca-supply = <&reg_1p2v>;
> > +               vcc-supply = <&reg_1p2v>;
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       port@0 {
> > +                               reg = <0>;
> > +                               sn65dsi86_in0: endpoint {
> > +                                       remote-endpoint = <&dsi0_out>;
> > +                               };
> > +                       };
> > +
> > +                       port@1 {
> > +                               reg = <1>;
> > +                               sn65dsi86_out0: endpoint {
> > +                                       remote-endpoint = <&mini_dp_con_in>;
> > +                               };
> > +                       };
> > +               };
> > +       };
> > +};
> > +
> >   &i2c3 {
> >          pinctrl-0 = <&i2c3_pins>;
> >          pinctrl-names = "default";
> > @@ -361,6 +451,11 @@ i2c0_pins: i2c0 {
> >                  function = "i2c0";
> >          };
> >
> > +       i2c1_pins: i2c1 {
> > +               groups = "i2c1";
> > +               function = "i2c1";
> > +       };
> > +
> >          i2c3_pins: i2c3 {
> >                  groups = "i2c3";
> >                  function = "i2c3";
>
> Missing:
>
>          irq0_pins: irq0 {
>                  groups = "intc_ex_irq0_a";
>                  function = "intc_ex";
>          };
>
> I'll fix that up while applying.

Thanks!

 Tomi

> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v6.14.
>
> Gr{oetje,eeting}s,
>
>                          Geert