On Thu, Dec 05, 2024 at 04:07:45PM -0800, Saravana Kannan wrote:
On Thu, Dec 5, 2024 at 4:06 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
On Wed, Dec 4, 2024 at 3:29 PM Sasha Levin <sashal@xxxxxxxxxx> wrote:
>
> From: Saravana Kannan <saravanak@xxxxxxxxxx>
>
> [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ]
>
> fwnode needs to be set for a device for fw_devlink to be able to
> track/enforce its dependencies correctly. Without this, you'll see error
> messages like this when the supplier has probed and tries to make sure
> all its fwnode consumers are linked to it using device links:
>
> mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0
>
> Reported-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/
> Tested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
> Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20241024061347.1771063-2-saravanak@xxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
As mentioned in the original cover letter:
PSA: Do not pull any of these patches into stable kernels. fw_devlink
had a lot of changes that landed in the last year. It's hard to ensure
cherry-picks have picked up all the dependencies correctly. If any of
these really need to get cherry-picked into stable kernels, cc me and
wait for my explicit Ack.
Is there a pressing need for this in 4.19?
I copy pasted this into several replies. In all those cases I meant
the kernel version mentioned in the subject.
I'll drop this and the other patch you've pointed out, thanks!
--
Thanks,
Sasha
