On Tue, Dec 10, 2024 at 3:14 AM Will Deacon <will@xxxxxxxxxx> wrote: > > Hi Rob, > > On Mon, Oct 28, 2024 at 02:31:36PM -0700, Rob Clark wrote: > > From: Rob Clark <robdclark@xxxxxxxxxxxx> > > > > This series extends io-pgtable-arm with a method to retrieve the page > > table entries traversed in the process of address translation, and then > > beefs up drm/msm gpu devcore dump to include this (and additional info) > > in the devcore dump. > > > > This is a respin of https://patchwork.freedesktop.org/series/94968/ > > (minus a patch that was already merged) > > > > v2: Fix an armv7/32b build error in the last patch > > v3: Incorperate Will Deacon's suggestion to make the interface > > callback based. > > v4: Actually wire up the callback > > v5: Drop the callback approach > > v6: Make walk-data struct pgtable specific and rename > > io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data > > v7: Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty() > > v8: Pass pte pointer to callback so it can modify the actual pte > > v9: Fix selftests_running case > > v10: Call visit cb for all nodes traversed, leave the decision about > > whether to care about non-leaf nodes to the callback > > Do you plan to respin this? I see Mostafa left a proposal on patch 3. Yeah, his suggestion looked reasonable. I'll try to get back to this patchset today. BR, -R