Hi Nick, kernel test robot noticed the following build errors: [auto build test ERROR on 40384c840ea1944d7c5a392e8975ed088ecf0b37] url: https://github.com/intel-lab-lkp/linux/commits/Nick-Chan/dt-bindings-leds-backlight-apple-dwi-bl-Add-bindings-for-Apple-DWI-backlight/20241207-013254 base: 40384c840ea1944d7c5a392e8975ed088ecf0b37 patch link: https://lore.kernel.org/r/20241206172735.4310-3-towinchenmi%40gmail.com patch subject: [PATCH 2/3] backlight: dwi_bl: Add Apple DWI backlight driver config: arc-randconfig-001-20241207 (https://download.01.org/0day-ci/archive/20241207/202412070721.9tZI9Ogl-lkp@xxxxxxxxx/config) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241207/202412070721.9tZI9Ogl-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202412070721.9tZI9Ogl-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/video/backlight/dwi_bl.c: In function 'dwi_bl_update_status': >> drivers/video/backlight/dwi_bl.c:46:16: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration] 46 | cmd |= FIELD_PREP(DWI_BL_CMD_DATA, brightness); | ^~~~~~~~~~ drivers/video/backlight/dwi_bl.c: In function 'dwi_bl_get_brightness': >> drivers/video/backlight/dwi_bl.c:61:16: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration] 61 | return FIELD_GET(DWI_BL_CMD_DATA, cmd); | ^~~~~~~~~ cc1: some warnings being treated as errors vim +/FIELD_PREP +46 drivers/video/backlight/dwi_bl.c 37 38 static int dwi_bl_update_status(struct backlight_device *bl) 39 { 40 struct apple_dwi_bl *dwi_bl = bl_get_data(bl); 41 42 int brightness = backlight_get_brightness(bl); 43 44 u32 cmd = 0; 45 > 46 cmd |= FIELD_PREP(DWI_BL_CMD_DATA, brightness); 47 cmd |= FIELD_PREP(DWI_BL_CMD_TYPE, DWI_BL_CMD_TYPE_SET_BRIGHTNESS); 48 49 writel(cmd, dwi_bl->base + DWI_BL_CMD); 50 writel(DWI_BL_CTL_SEND, dwi_bl->base + DWI_BL_CTL); 51 52 return 0; 53 } 54 55 static int dwi_bl_get_brightness(struct backlight_device *bl) 56 { 57 struct apple_dwi_bl *dwi_bl = bl_get_data(bl); 58 59 u32 cmd = readl(dwi_bl->base + DWI_BL_CMD); 60 > 61 return FIELD_GET(DWI_BL_CMD_DATA, cmd); 62 } 63 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki