On Fri, 6 Dec 2024 at 18:13, Lizhi Hou <lizhi.hou@xxxxxxx> wrote: > > > On 12/6/24 09:52, Mike Lothian wrote: > > On Fri, 6 Dec 2024 at 17:10, Lizhi Hou <lizhi.hou@xxxxxxx> wrote: > >> Hi Mike, > >> > >> > >> How did you install npu.sbin.1.5.2.380? There should be a symlink > >> npu.sbin which points to npu.sbin.1.5.2.380. > >> > >> https://gitlab.com/kernel-firmware/linux-firmware/-/blob/main/WHENCE?ref_type=heads#L2719 > >> > >> > >> Thanks, > >> > >> Lizhi > >> > >> On 12/5/24 07:44, Mike Lothian wrote: > >>> Hi > >>> > >>> I needed to add the following to get things compiling for me > >>> > >>> > >>> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c > >>> b/drivers/accel/amdxdna/amdxdna_mailbox.c > >>> index fe684f463b945..79b9801935e71 100644 > >>> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c > >>> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c > >>> @@ -6,6 +6,7 @@ > >>> #include <drm/drm_device.h> > >>> #include <drm/drm_managed.h> > >>> #include <linux/bitfield.h> > >>> +#include <linux/interrupt.h> > >>> #include <linux/iopoll.h> > >>> > >>> #define CREATE_TRACE_POINTS > >>> > >>> > >>> I also had to rename the firmware in /lib/firmware/amdnpu/1502_00/ > >>> from npu.sbin.1.5.2.380 to npu.sbin > >>> > >>> Cheers > >>> > >>> Mike > >>> > >>> > > It's just a clone of > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git > > in /lib/firmware, there's definately no symlink in > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/amdnpu/1502_00 > > Did you build a package (e.g. make deb) and install it? I saw the > symlink with the generated package. > > dpkg -c dist/linux-firmware-upstream_20241110-135-g06aea4d8_all.deb | > grep amdnpu.1502 > drwxr-xr-x root/root 0 2024-12-06 10:05 > ./lib/firmware/updates/amdnpu/1502_00/ > -rw-r--r-- root/root 246656 2024-12-06 10:05 > ./lib/firmware/updates/amdnpu/1502_00/npu.sbin.1.5.2.380 > lrwxrwxrwx root/root 0 2024-12-06 10:05 > ./lib/firmware/updates/amdnpu/1502_00/npu.sbin -> npu.sbin.1.5.2.380 > > > Thanks, > > Lizhi > Hi, it looks like I've been lucky in the past not needing anything with a symlink "make install" fixed the symlink, thanks
