On Mon, Dec 02, 2024 at 09:13:22PM +0800, Yongbang Shi wrote: > From: baihan li <libaihan@xxxxxxxxxx> > > To support DP interface displaying in hibmc driver. Add > a encoder and connector for DP modual. The HPD function > and get_edid function will be add in next series, so temporarily > using 1024x768 as default in hibmc_dp_connector_get_modes() > > Signed-off-by: Baihan Li <libaihan@xxxxxxxxxx> > Signed-off-by: Yongbang Shi <shiyongbang@xxxxxxxxxx> > --- > ChangeLog: > v5 -> v6: > - adding hpd and get_edid comments in the beginning of patch, suggested by Dmitry Baryshkov. > v3 -> v4: > - static inline hibmc_dp_prepare(), suggested by Dmitry Baryshkov. > --- > drivers/gpu/drm/hisilicon/hibmc/Makefile | 2 +- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 118 ++++++++++++++++++ > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 12 ++ > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 5 + > 4 files changed, 136 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > index 8c488c98ac97..388e4fb4fcaf 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > @@ -28,6 +28,10 @@ > #include "hibmc_drm_drv.h" > #include "hibmc_drm_regs.h" > > +#define HIBMC_DP_HOST_SERDES_CTRL 0x1f001c > +#define HIBMC_DP_HOST_SERDES_CTRL_VAL 0x8A00 > +#define HIBMC_DP_HOST_SERDES_CTRL_MASK 0x7FFFF Nit: lowercase hex Other than that: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
