On Thu, 05 Dec 2024, Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> wrote:
> Hi Jani,
>
> On Thu, Dec 05, 2024 at 11:49:34AM +0200, Jani Nikula wrote:
>> Use the drm_printer based printer to get the device specific printing of
>> the hex dump.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> ...
>
>> -static void
>> -intel_dump_buffer(const char *prefix, const u8 *buf, size_t len)
>> -{
>> - if (!drm_debug_enabled(DRM_UT_KMS))
>> - return;
>
> We lose this check now, anyway,
That now depends on the drm_printer, as it should.
Moreover, intel_crtc_state_dump() already has that check, so this is
completely redundant.
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
Thanks,
Jani.
>
> Thanks,
> Andi
--
Jani Nikula, Intel
