On 03/12/2024 14:41, Michal Wilczynski wrote:
> +
> +title: T-HEAD TH1520 Power Domain Controller
> +
> +maintainers:
> + - Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> +
> +description: |
> + The T-HEAD TH1520 SoC includes a power domain controller responsible for
> + managing the power states of various hardware domains such as the GPU.
> +
> + This binding describes the power domain controller node, which can be used by
Do not describe the binding. Describe the hardware. Entire paragraph
feels pointless.
> + devices to manage their power domains.
> +
> +properties:
> + compatible:
> + const: "thead,th1520-pd"
You never tested the code you sent. Drop quotes. Limited review follows.
> +
> + thead,vosys-regmap:
NAK.
'reg' is for this.
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + Phandle to a syscon node representing the shared register space of the VO (Video Output) subsystem.
Please wrap code according to coding style (checkpatch is not a coding
style description, but only a tool).
> + This register space includes both clock control registers and other control registers used for
> + operations like resetting the GPU. Since these registers reside in the same address space,
> + access to them is coordinated through a shared syscon regmap provided by the specified syscon node.
> +
> + '#power-domain-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - thead,vosys-regmap
> + - '#power-domain-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + vosys_regmap: vosys@ffef528000 {
> + compatible = "syscon";
> + reg = <0xff 0xef528000 0x0 0x1000>;
> + };
Drop, not related.
Best regards,
Krzysztof
