On 03/12/2024 14:41, Michal Wilczynski wrote:
> As support for clocks from new subsystems is being added to the T-Head
> TH1520 SoC, the header file name should reflect this broader scope. The
No, there is no such rule, so "should" is not appropriate.
> existing header file 'thead,th1520-clk-ap.h' includes the '-ap' suffix,
> indicating it's specific to the Application Processor (AP) subsystem.
>
> Rename the header file to 'thead,th1520-clk.h' to generalize it for all
> subsystems. Update all references to this header file accordingly.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/clock/thead,th1520-clk-ap.yaml | 4 ++--
> .../devicetree/bindings/mailbox/thead,th1520-mbox.yaml | 2 +-
> MAINTAINERS | 2 +-
> arch/riscv/boot/dts/thead/th1520.dtsi | 2 +-
> drivers/clk/thead/clk-th1520.h | 2 +-
> .../clock/{thead,th1520-clk-ap.h => thead,th1520-clk.h} | 0
Don't mix driver, bindings and DTS. See checkpatch warning. Don't rename
files just because you prefer other names.
Best regards,
Krzysztof
