On Tue, Dec 03, 2024 at 09:01:31AM +0100, Krzysztof Kozlowski wrote: > On 03/12/2024 04:31, Abhinav Kumar wrote: > > Document the assigned-clock-parents better for the DP controller node > > to indicate its functionality better. > > > You change the clocks entirely, not "document". I would say that's an > ABI break if it really is a Linux requirement. You could avoid any > problems by just dropping the property from binding. But if you take a look at the existing usage, the proposed change matches the behaviour. So, I'd say, it's really a change that makes documentation follow the actual hardware. > > > > > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index 35ae2630c2b3..9fe2bf0484d8 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -72,8 +72,8 @@ properties: > > > > assigned-clock-parents: > > items: > > - - description: phy 0 parent > > - - description: phy 1 parent > > + - description: Link clock PLL output provided by PHY block > > + - description: Stream 0 pixel clock PLL output provided by PHY block > > > Best regards, > Krzysztof -- With best wishes Dmitry
