Re: [PATCH v2] drm: Drop explicit initialization of struct i2c_device_id::driver_data to 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Dec 2, 2024 at 3:47 AM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
>
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
>
> While add it, also remove commas after the sentinel entries.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
>
> changes since (implicit) v1
> (https://lore.kernel.org/dri-devel/20240516123837.81664-2-u.kleine-koenig@xxxxxxxxxxxxxx):
>
>  - Update author email address
>  - Rebase (trivially) to latest next
>  - Also convert drivers/gpu/drm/bridge/ite-it6263.c (which is new since
>    the series was orginally sent in May)
>
> Best regards
> Uwe
>
>  drivers/gpu/drm/bridge/analogix/analogix-anx6345.c       | 2 +-
>  drivers/gpu/drm/bridge/analogix/anx7625.c                | 2 +-
>  drivers/gpu/drm/bridge/chrontel-ch7033.c                 | 2 +-
>  drivers/gpu/drm/bridge/ite-it6263.c                      | 2 +-
>  drivers/gpu/drm/bridge/ite-it6505.c                      | 2 +-
>  drivers/gpu/drm/bridge/lontium-lt8912b.c                 | 4 ++--
>  drivers/gpu/drm/bridge/lontium-lt9611.c                  | 2 +-
>  drivers/gpu/drm/bridge/lontium-lt9611uxc.c               | 2 +-
>  drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 8 ++++----
>  drivers/gpu/drm/bridge/nxp-ptn3460.c                     | 4 ++--
>  drivers/gpu/drm/bridge/sii902x.c                         | 4 ++--
>  drivers/gpu/drm/bridge/sii9234.c                         | 4 ++--
>  drivers/gpu/drm/bridge/sil-sii8620.c                     | 4 ++--
>  drivers/gpu/drm/bridge/tc358767.c                        | 2 +-
>  drivers/gpu/drm/bridge/tc358768.c                        | 4 ++--
>  drivers/gpu/drm/bridge/ti-dlpc3433.c                     | 2 +-
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c                    | 4 ++--
>  drivers/gpu/drm/bridge/ti-tfp410.c                       | 2 +-
>  drivers/gpu/drm/i2c/ch7006_drv.c                         | 2 +-
>  drivers/gpu/drm/i2c/sil164_drv.c                         | 2 +-
>  drivers/gpu/drm/i2c/tda9950.c                            | 4 ++--
>  drivers/gpu/drm/i2c/tda998x_drv.c                        | 2 +-
>  22 files changed, 33 insertions(+), 33 deletions(-)

This conflicts with commit dbf7986f8a56 ("drm/bridge: Constify struct
i2c_device_id"). Can you rebase, please?

Other than that:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux