On Mon, Dec 02, 2024 at 09:13:18PM +0800, Yongbang Shi wrote:
> From: baihan li <libaihan@xxxxxxxxxx>
>
> Add dp aux read/write functions. They are basic functions
> and will be used later.
>
> Signed-off-by: Baihan Li <libaihan@xxxxxxxxxx>
> Signed-off-by: Yongbang Shi <shiyongbang@xxxxxxxxxx>
> ---
> ChangeLog:
> v5 -> v6:
> - adding do{} while(0) in macro defination function, suggested by Dmitry Baryshkov.
> v4 -> v5:
> - fixing build errors reported by kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411131438.RZWYrWTE-lkp@xxxxxxxxx/
> v3 -> v4:
> - retun error codes in result incorrect branch, suggested by Dmitry Baryshkov.
> - replacing all ret= with returns, suggested by Dmitry Baryshkov.
> - moving the comment below the judgment statement, suggested by Dmitry Baryshkov.
> - moving definations to the source file and clearing headers, suggested by Dmitry Baryshkov.
> - reanaming dp_prefix to hibmc_dp_prefix, suggested by Dmitry Baryshkov.
> - changing hibmc_dp_reg_write_field to static inline and lock, suggested by Dmitry Baryshkov.
> - moving some structs to later patch, suggested by Dmitry Baryshkov.
> v2 -> v3:
> - put the macro definations in latter patch where they are actually used, suggested by Dmitry Baryshkov.
> - rename some macro definations to make them sensible, suggested by Dmitry Baryshkov.
> - using FIELD_PREP and FIELD_GET, suggested by Dmitry Baryshkov.
> - using DP_DPCD_REV_foo, suggested by Dmitry Baryshkov.
> - fix build errors reported by kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410250305.UHKDhtxy-lkp@xxxxxxxxx/
> v1 -> v2:
> - using drm_dp_aux frame implement dp aux read and write functions, suggested by Jani Nikula.
> - using drm dp header files' dp macros instead, suggested by Andy Yan.
> v1:https://lore.kernel.org/all/20240930100610.782363-1-shiyongbang@xxxxxxxxxx/
> ---
> drivers/gpu/drm/hisilicon/hibmc/Makefile | 3 +-
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 164 +++++++++++++++++++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 42 +++++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 27 +++
> 4 files changed, 235 insertions(+), 1 deletion(-)
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h
> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
--
With best wishes
Dmitry
