On Mon, Dec 02, 2024 at 06:31:44PM +0800, Xiangxu Yin wrote:
>
>
> On 11/29/2024 4:18 PM, Krzysztof Kozlowski wrote:
> > On 29/11/2024 08:57, Xiangxu Yin wrote:
> >> +static int qmp_usbc_com_init(struct phy *phy)
> >> {
> >> struct qmp_usbc *qmp = phy_get_drvdata(phy);
> >> - const struct qmp_phy_cfg *cfg = qmp->cfg;
> >> - void __iomem *pcs = qmp->pcs;
> >> + int num_vregs;
> >> u32 val = 0;
> >> int ret;
> >> + unsigned int reg_pwr_dn;
> >>
> >> - ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
> >> + if (qmp->type == QMP_PHY_USBC_USB) {
> >
> >
> > Sorry, all this code is unreviewable. Organize your changes in logical,
> > reviewable chunks.
> >
> Will create new patch list and seperate patchsets.
Please respond to the comment regarding the single PHY vs multiple PHYs
first.
> >> + struct qmp_phy_usb_cfg *cfg = to_usb_cfg(qmp);
> >> +
> >> + num_vregs = cfg->num_vregs;
> >> + reg_pwr_dn = cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL];
> >> + } else {
> >
--
With best wishes
Dmitry
