On 2024/11/27 21:41, Dmitry Baryshkov wrote:
On Wed, Nov 27, 2024 at 04:15:49PM +0800, Yongxing Mou wrote:Add support for eDP PHY v5 found on the Qualcomm QCS8300 platform. Signed-off-by: Yongxing Mou <quic_yongmou@xxxxxxxxxxx> --- drivers/phy/qualcomm/phy-qcom-edp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index f1b51018683d51df064f60440864c6031638670c..90e0a399c25299ad1b2fb5df8512ba3888661046 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -532,6 +532,13 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v4 = { .com_configure_ssc = qcom_edp_com_configure_ssc_v4, };+static const struct qcom_edp_phy_cfg qcs8300_dp_phy_cfg = {+ .is_edp = false, + .aux_cfg = edp_phy_aux_cfg_v5, + .swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg_v5, + .ver_ops = &qcom_edp_phy_ops_v4, +}; + static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = { .is_edp = false, .aux_cfg = edp_phy_aux_cfg_v5, @@ -1133,6 +1140,7 @@ static int qcom_edp_phy_probe(struct platform_device *pdev) }static const struct of_device_id qcom_edp_phy_match_table[] = {+ { .compatible = "qcom,qcs8300-edp-phy", .data = &qcs8300_dp_phy_cfg, },If the setup is the same as SA8775p and you don't expect any QCS8300-specific tunings, please reuse sa8775p as a fallback compat.
Got it. it can reuse sa8775p, will update it in next patchset.
{ .compatible = "qcom,sa8775p-edp-phy", .data = &sa8775p_dp_phy_cfg, }, { .compatible = "qcom,sc7280-edp-phy", .data = &sc7280_dp_phy_cfg, }, { .compatible = "qcom,sc8180x-edp-phy", .data = &sc7280_dp_phy_cfg, }, -- 2.34.1
