On Thu, Nov 28, 2024 at 04:46:53PM +0800, Sui Jingfeng wrote: > Hi, > > On 2024/11/25 17:33, Liu Ying wrote: > > i.MX8qxp Display Controller display engine consists of all processing > > units that operate in a display clock domain. Add minimal feature > > support with FrameGen and TCon so that the engine can output display > > timings. The display engine driver as a master binds FrameGen and > > TCon drivers as components. While at it, the display engine driver > > is a component to be bound with the upcoming DRM driver. > > > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > > --- > > v4: > > * Use regmap to define register map for all registers. (Dmitry) > > * Use regmap APIs to access registers. (Dmitry) > > * Inline some small functions. (Dmitry) > > > Why? > > Its seems that the switch to regmap APIs is not very necessary, > as ioremap/writel/readl are simple enough and easier to use. > > Isn't that this just introduce an intermediate layer? It's okay > for display bridges/panels that behind I2C bus or SPI bus. But > then, why drm/msm still haven't be converted to use the regmap > APIs ? > > Just a few questions, has no opinions to your patch. Please respond to the original review comment. Then we might be able to discuss if the suggested change was logical or not. Discussing changelog doesn't make sense becasue there is no context here. -- With best wishes Dmitry
