On Thu, Nov 28, 2024 at 09:46:33AM +0100, Andrej Picej wrote: > On 27. 11. 24 16:16, Rob Herring wrote: > > On Wed, Nov 27, 2024 at 11:30:29AM +0100, Andrej Picej wrote: > > > From: Janine Hagemann <j.hagemann@xxxxxxxxx> > > > > > > Add an optional property to change LVDS output voltage. This depends on > > > the connected display specifications. With this property we directly set > > > the LVDS_VCOM (0x19) register. > > > Better register property mapping would be quite tricky. Please check > > > bridge's datasheet for details on how register values set the LVDS > > > data lines and LVDS clock output voltage. > > > > > > Signed-off-by: Janine Hagemann <j.hagemann@xxxxxxxxx> > > > Signed-off-by: Andrej Picej <andrej.picej@xxxxxxxxx> > > > --- > > > .../bindings/display/bridge/ti,sn65dsi83.yaml | 14 +++++++++++++- > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > > index 48a97bb3e2e0..5b2c0c281824 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > > @@ -58,6 +58,12 @@ properties: > > > - const: 2 > > > - const: 3 > > > - const: 4 > > > + ti,lvds-vcom: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: LVDS output voltage configuration. This defines > > > + LVDS_VCOM (0x19) register value. Check bridge's datasheet for > > > + details on how register values set the LVDS data lines and > > > + LVDS clock output voltage. > > > > Constraints? 0 - 2^32 are all valid values? > > Not really, only first 6 bits, which also means that this can be uint8 then. > Will fix with other issues. Also, generally speaking directly using register values is really frowned upon, even more so when they match a value expressed in a standard unit. Maxime
Attachment:
signature.asc
Description: PGP signature
