On Tue, 26 Nov 2024 at 17:46, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > +allOf: > > + - $ref: dsi-controller.yaml# ... > > +patternProperties: > > + "^panel@[0-3]$": true > > These look unusual. Is this a DSI controller? If so, then reference > dsi-controller. See other bindings how this is done. This is a DSI controller, as referenced above. Those properties are from dsi-controller.yaml > > +properties: > > + compatible: > > + items: > > + - enum: > > + - apple,j293-summit > > + - apple,j493-summit > > + - const: apple,summit > > Summit tells me nothing - no description, title repeats it, so I suggest > using device specific compatible. The j293/j493 are the device-specific compatibles, those are chassis names for the specific laptops the panel is present in. > No, these cannot be true without definition. Again, please open existing > bindings and use them as example. You probably miss here some reference, > but max-brightness for panel is a bit confusing. I asked already and did > not get answer: isn't this backlight property? What is this device - > backlight or panel? If panel, then what bus? Per my response on previous version, it's both, kind of. This is a self-emissive panel on a mipi-dsi bus, which can change brightness in response to mipi dcs backlight commands.
