On Fri, 22 Nov 2024, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index b2b6a8e49dda46f1cb3b048ef7b28356dd3aaa4e..8ed58e482fac4662b659276e8bc17690e1fdb9b7 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -280,4 +280,9 @@ void drm_framebuffer_print_info(struct drm_printer *p, unsigned int indent, > const struct drm_framebuffer *fb); > void drm_framebuffer_debugfs_init(struct drm_device *dev); > > +/* drm_connector_hdmi_codec.c */ > + > +int drm_connector_hdmi_codec_init(struct drm_connector *connector); > +void drm_connector_hdmi_codec_cleanup(struct drm_connector *connector); > + > #endif /* __DRM_INTERNAL_H__ */ Better fit in drm_crtc_internal.h or drm_crtc_helper_internal.h? Maybe we could use an internal header inside display/. Or just 1:1 drm_foo_internal.h for every drm_foo.c to keep things simple and have fewer interdependencies. BR, Jani. -- Jani Nikula, Intel