> On Thu, Nov 21, 2024 at 05:56:00PM +0530, Arun R Murthy wrote: > > CRTC properties have been added for enable/disable histogram, reading > > the histogram data and writing the IET data. > > "HISTOGRAM_EN" is the crtc property to enable/disable the global > > histogram and takes a value 0/1 accordingly. > > "Histogram" is a crtc property to read the binary histogram data. > > "Global IET" is a crtc property to write the IET binary LUT data. > > > > v2: Read the histogram blob data before sending uevent (Jani) > > v3: use drm_property_replace_blob_from_id (Vandita) > > Add substruct for histogram in intel_crtc_state (Jani) > > v4: Rebased after addressing comments on patch 1 > > v5: histogram check with old/new crtc_state (Suraj) > > v6: Rebase > > > > Signed-off-by: Arun R Murthy <arun.r.murthy@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/display/intel_atomic.c | 5 + > > drivers/gpu/drm/i915/display/intel_crtc.c | 166 +++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_crtc.h | 5 + > > drivers/gpu/drm/i915/display/intel_display.c | 16 ++ > > .../drm/i915/display/intel_display_types.h | 13 ++ > > .../gpu/drm/i915/display/intel_histogram.c | 6 + > > 6 files changed, 210 insertions(+), 1 deletion(-) > > Please provide the documentation for these properties: binary format, etc. Also, > ideally such a properties should be defined in a vendor-neutral way, so that > other drivers also can implement support for similar functionality. > I assumed that there are no other users of this histogram. Hence had it internal to i915 driver. Will move these properties to drm-crtc, making it useable by other users as well. Thanks and Regards, Arun R Murthy --------------------
