Re: [PATCH v2 6/9] drm/msm/dsi: Add support for QCS615

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/11/14 21:41, Dmitry Baryshkov wrote:
On Thu, 14 Nov 2024 at 15:32, Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:

On 13.11.2024 12:51 PM, Fange Zhang wrote:
From: Li Liu <quic_lliu6@xxxxxxxxxxx>

Add support for DSI 2.3.1 (block used on QCS615).
Add phy configuration for QCS615

Signed-off-by: Li Liu <quic_lliu6@xxxxxxxxxxx>
Signed-off-by: Fange Zhang <quic_fangez@xxxxxxxxxxx>
---
  drivers/gpu/drm/msm/dsi/dsi_cfg.c          | 17 +++++++++++++++++
  drivers/gpu/drm/msm/dsi/dsi_cfg.h          |  1 +
  drivers/gpu/drm/msm/dsi/phy/dsi_phy.c      |  2 ++
  drivers/gpu/drm/msm/dsi/phy/dsi_phy.h      |  1 +
  drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 21 +++++++++++++++++++++
  5 files changed, 42 insertions(+)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
index 10ba7d153d1cfc9015f527c911c4658558f6e29e..edbe50305d6e85fb615afa41f3b0db664d2f4413 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
@@ -221,6 +221,21 @@ static const struct msm_dsi_config sc7280_dsi_cfg = {
       },
  };

+static const struct regulator_bulk_data qcs615_dsi_regulators[] = {
+     { .supply = "vdda", .init_load_uA = 21800 },
+};

I believe refgen is also present here and you can reuse dsi_v2_4_regulators

This was in feedback for v1... And the patch should be further split,
having DSI and PHY parts separately.
yes, will split and fix in next patch





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux