Re: [PATCH] drm/radeon: Constify struct pci_device_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 15.11.24 um 18:26 schrieb Christophe JAILLET:
'struct pci_device_id' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
    text	   data	    bss	    dec	    hex	filename
   11984	  28672	     44	  40700	   9efc	drivers/gpu/drm/radeon/radeon_drv.o

After:
=====
    text	   data	    bss	    dec	    hex	filename
   40000	    664	     44	  40708	   9f04	drivers/gpu/drm/radeon/radeon_drv.o

Mhm that's a bit more than "some data" :)

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Acked-by: Christian König <christian.koenig@xxxxxxx>

---
Compile tested-only.
---
  drivers/gpu/drm/radeon/radeon_drv.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 23d6d1a2586d..5e958cc223f4 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -248,10 +248,9 @@ int radeon_cik_support = 1;
  MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled (default), 0 = disabled)");
  module_param_named(cik_support, radeon_cik_support, int, 0444);
-static struct pci_device_id pciidlist[] = {
+static const struct pci_device_id pciidlist[] = {
  	radeon_PCI_IDS
  };
-
  MODULE_DEVICE_TABLE(pci, pciidlist);
static const struct drm_driver kms_driver;




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux