On Wed, 13 Nov 2024 16:42:54 +0100 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote: > @@ -541,17 +547,4 @@ int panthor_device_suspend(struct device *dev) > clk_disable_unprepare(ptdev->clks.core); > atomic_set(&ptdev->pm.state, PANTHOR_DEVICE_PM_STATE_SUSPENDED); > return 0; > - > -err_set_active: > - /* If something failed and we have to revert back to an > - * active state, we also need to clear the MMIO userspace > - * mappings, so any dumb pages that were mapped while we > - * were trying to suspend gets invalidated. > - */ > - mutex_lock(&ptdev->pm.mmio_lock); > - atomic_set(&ptdev->pm.state, PANTHOR_DEVICE_PM_STATE_ACTIVE); > - unmap_mapping_range(ptdev->base.anon_inode->i_mapping, > - DRM_PANTHOR_USER_MMIO_OFFSET, 0, 1); > - mutex_unlock(&ptdev->pm.mmio_lock); > - return ret; > } This chunk should be in patch 3.