On Fri, Nov 08, 2024 at 03:20:48PM +0100, Maxime Ripard wrote:
> On Fri, Nov 01, 2024 at 02:25:05AM +0200, Dmitry Baryshkov wrote:
> > Use new drm_hdmi_connector_mode_valid() helper instead of a
> > module-specific copy.
> >
> > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +-----------
> > 1 file changed, 1 insertion(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> > index b3649449de3026784ae2f3466906403a0b6e3b47..54b72fe220afacc208b3fd48d5160031127ea14a 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> > @@ -205,16 +205,6 @@ static int sun4i_hdmi_connector_atomic_check(struct drm_connector *connector,
> > return 0;
> > }
> >
> > -static enum drm_mode_status
> > -sun4i_hdmi_connector_mode_valid(struct drm_connector *connector,
> > - struct drm_display_mode *mode)
> > -{
> > - unsigned long long rate = drm_hdmi_compute_mode_clock(mode, 8,
> > - HDMI_COLORSPACE_RGB);
> > -
> > - return sun4i_hdmi_connector_clock_valid(connector, mode, rate);
> > -}
> > -
> > static int sun4i_hdmi_get_modes(struct drm_connector *connector)
> > {
> > struct sun4i_hdmi *hdmi = drm_connector_to_sun4i_hdmi(connector);
> > @@ -269,7 +259,7 @@ static const struct drm_connector_hdmi_funcs sun4i_hdmi_hdmi_connector_funcs = {
> >
> > static const struct drm_connector_helper_funcs sun4i_hdmi_connector_helper_funcs = {
> > .atomic_check = sun4i_hdmi_connector_atomic_check,
> > - .mode_valid = sun4i_hdmi_connector_mode_valid,
> > + .mode_valid = drm_hdmi_connector_mode_valid,
> > .get_modes = sun4i_hdmi_get_modes,
> > };
>
> It's only slightly related, but the atomic_check implementation that
> will be the last (direct) user of sun4i_hdmi_clock_valid is wrong and
> doesn't call drm_atomic_helper_connector_hdmi_check
I can send a patch fixing this, but I can't test it.
--
With best wishes
Dmitry
