On Tue, Nov 05, 2024 at 08:19:00AM -0600, Rob Herring wrote:
> On Tue, Nov 05, 2024 at 02:52:29PM +0900, Hironori KIKUCHI wrote:
> > A panel assembly is changed in the recent revision of Anbernic RG35XX
> > Plus, so the `anbernic,rg35xx-plus-panel` identifier is neither suitable
> > nor unique for the panel anymore.
> >
> > Fortunately, the panel can be distinguished by a label printed on the
> > FPC cable, so use the label "WL-355608-A8" as an identifier instead.
> >
> > Signed-off-by: Hironori KIKUCHI <kikuchan98@xxxxxxxxx>
> > ---
> > ...rg35xx-plus-panel.yaml => anbernic,wl-355608-a8.yaml} | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> > rename Documentation/devicetree/bindings/display/panel/{anbernic,rg35xx-plus-panel.yaml => anbernic,wl-355608-a8.yaml} (83%)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> > similarity index 83%
> > rename from Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml
> > rename to Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> > index 1d67492ebd3..5e8afbea690 100644
> > --- a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.yaml
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > %YAML 1.2
> > ---
> > -$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-plus-panel.yaml#
> > +$id: http://devicetree.org/schemas/display/panel/anbernic,wl-355608-a8.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > title: Anbernic RG35XX series (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
> > @@ -16,13 +16,14 @@ allOf:
> > properties:
> > compatible:
> > oneOf:
> > - - const: anbernic,rg35xx-plus-panel
> > + - const: anbernic,wl-355608-a8
> > - items:
> > - enum:
> > - anbernic,rg35xx-2024-panel
> > - anbernic,rg35xx-h-panel
> > - anbernic,rg35xx-sp-panel
> > - - const: anbernic,rg35xx-plus-panel
> > + - anbernic,rg35xx-plus-panel
> > + - const: anbernic,wl-355608-a8
> >
> > reg:
> > maxItems: 1
> > @@ -47,7 +48,7 @@ examples:
> > #size-cells = <0>;
> >
> > panel@0 {
> > - compatible = "anbernic,rg35xx-plus-panel";
> > + compatible = "anbernic,wl-355608-a8";
>
> This is an ABI break. You can't just change compatibles.
>
> The old panel should correspond to the existing compatible. Add a new
> compatible for the new panel. The names might not be ideal, but you are
> stuck with them.
>
> There's exceptions if things are new and not yet in use, but you have to
> explain that in the commit msg.
We already had one faff over renaming this panel a few months ago:
d682eef93ebf ("dt-bindings: display: panel: Rename WL-355608-A8 panel to rg35xx-*-panel")
I don't agree with renaming it again.
Attachment:
signature.asc
Description: PGP signature
