On 26/10/24 - 11:11, Maíra Canal wrote:
> Hi Louis,
>
> On 07/10/24 13:46, Louis Chauvet wrote:
> > The formats XRGB8888 and ARGB8888 were already supported.
> > Add the support for:
> > - XBGR8888
> > - RGBX8888
> > - BGRX8888
> > - ABGR8888
> > - RGBA8888
> > - BGRA8888
> >
> > Signed-off-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/vkms/vkms_formats.c | 18 ++++++++++++++++++
> > drivers/gpu/drm/vkms/vkms_plane.c | 6 ++++++
> > 2 files changed, 24 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c
> > index 8f1bcca38148..b5a38f70c62b 100644
> > --- a/drivers/gpu/drm/vkms/vkms_formats.c
> > +++ b/drivers/gpu/drm/vkms/vkms_formats.c
> > @@ -432,8 +432,14 @@ static void R4_read_line(const struct vkms_plane_state *plane, int x_start,
> > READ_LINE_ARGB8888(XRGB8888_read_line, px, 255, px[2], px[1], px[0])
> > +READ_LINE_ARGB8888(XBGR8888_read_line, px, 255, px[0], px[1], px[2]) > +READ_LINE_ARGB8888(RGBX8888_read_line, px, 255, px[3], px[2], px[1])
>
> I'm not expert in colors, but is this correct? From what I understand,
> it should be:
Yes, this is correct, READ_LINE_ARGB8888 take the parameters as A, R, G,
B, so here 0xFF, px[2], px[1], px[0]
> READ_LINE_ARGB8888(RGBX8888_read_line, px, px[2], px[1], px[0], 255)
> ^R ^G ^B ^X
>
> > +READ_LINE_ARGB8888(BGRX8888_read_line, px, 255, px[1], px[2], px[3])
>
> Again, is this correct?
>
> Best Regards,
> - Maíra
>
> > READ_LINE_ARGB8888(ARGB8888_read_line, px, px[3], px[2], px[1], px[0])
> > +READ_LINE_ARGB8888(ABGR8888_read_line, px, px[3], px[0], px[1], px[2])
> > +READ_LINE_ARGB8888(RGBA8888_read_line, px, px[0], px[3], px[2], px[1])
> > +READ_LINE_ARGB8888(BGRA8888_read_line, px, px[0], px[1], px[2], px[3])
> > READ_LINE_16161616(ARGB16161616_read_line, px, px[3], px[2], px[1], px[0]);
> > @@ -637,8 +643,20 @@ pixel_read_line_t get_pixel_read_line_function(u32 format)
> > switch (format) {
> > case DRM_FORMAT_ARGB8888:
> > return &ARGB8888_read_line;
> > + case DRM_FORMAT_ABGR8888:
> > + return &ABGR8888_read_line;
> > + case DRM_FORMAT_BGRA8888:
> > + return &BGRA8888_read_line;
> > + case DRM_FORMAT_RGBA8888:
> > + return &RGBA8888_read_line;
> > case DRM_FORMAT_XRGB8888:
> > return &XRGB8888_read_line;
> > + case DRM_FORMAT_XBGR8888:
> > + return &XBGR8888_read_line;
> > + case DRM_FORMAT_RGBX8888:
> > + return &RGBX8888_read_line;
> > + case DRM_FORMAT_BGRX8888:
> > + return &BGRX8888_read_line;
> > case DRM_FORMAT_ARGB16161616:
> > return &ARGB16161616_read_line;
> > case DRM_FORMAT_XRGB16161616:
> > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> > index 67f891e7ac58..941a6e92a040 100644
> > --- a/drivers/gpu/drm/vkms/vkms_plane.c
> > +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> > @@ -14,7 +14,13 @@
> > static const u32 vkms_formats[] = {
> > DRM_FORMAT_ARGB8888,
> > + DRM_FORMAT_ABGR8888,
> > + DRM_FORMAT_BGRA8888,
> > + DRM_FORMAT_RGBA8888,
> > DRM_FORMAT_XRGB8888,
> > + DRM_FORMAT_XBGR8888,
> > + DRM_FORMAT_RGBX8888,
> > + DRM_FORMAT_BGRX8888,
> > DRM_FORMAT_XRGB16161616,
> > DRM_FORMAT_ARGB16161616,
> > DRM_FORMAT_RGB565,
> >
