On Sat, Oct 26, 2024 at 05:37:38PM +0800, Jinjie Ruan wrote: > dev_pm_qos_add_request() can fail, and it returns -EINVAL in case of > wrong parameters, return -ENOMEM if there's not enough memory to allocate > for data structures, and return -ENODEV if the device has just been > removed from the system. If it fails in msm_devfreq_init(), there is > no point in going on, also call dev_pm_qos_remove_request() in the next > error path is also meaningless > > Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") > Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx> > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > I'm sorry, a similar patch has already been sent: https://patchwork.freedesktop.org/series/140162/ -- With best wishes Dmitry