Hi, On 10/19/2024 12:09 AM, Jeffrey Hugo wrote: > On 10/17/2024 8:58 AM, Jacek Lawrynowicz wrote: >> From: Maciej Falkowski <maciej.falkowski@xxxxxxxxxxxxxxx> >> >> Add CONFIG_DRM_ACCEL_IVPU_DEBUG option that: >> - Adds -DDEBUG that enables printk regardless of the kernel config >> - Enables unsafe module params (that are now disabled by default) >> >> Signed-off-by: Maciej Falkowski <maciej.falkowski@xxxxxxxxxxxxxxx> >> Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx> >> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx> >> --- >> drivers/accel/ivpu/Kconfig | 10 ++++++++++ >> drivers/accel/ivpu/Makefile | 2 ++ >> drivers/accel/ivpu/ivpu_drv.c | 2 ++ >> drivers/accel/ivpu/ivpu_fw.c | 2 ++ >> drivers/accel/ivpu/ivpu_pm.c | 2 ++ >> 5 files changed, 18 insertions(+) >> >> diff --git a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig >> index e4d418b44626e..8858b32e05640 100644 >> --- a/drivers/accel/ivpu/Kconfig >> +++ b/drivers/accel/ivpu/Kconfig >> @@ -16,3 +16,13 @@ config DRM_ACCEL_IVPU >> and Deep Learning applications. >> If "M" is selected, the module will be called intel_vpu. >> + >> +config DRM_ACCEL_IVPU_DEBUG >> + bool "Intel NPU debug mode" >> + depends on DRM_ACCEL_IVPU >> + default n > > The default is N, so this is redundant, no? > Yes, I will remove it.
