On Thu, Oct 24, 2024 at 12:08 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Oct 23, 2024 at 11:13:41PM -0700, Saravana Kannan wrote: > > Probably easiest for Greg to pull in these changes? > > > > PSA: Do not pull any of these patches into stable kernels. fw_devlink > > had a lot of changes that landed in the last year. It's hard to ensure > > cherry-picks have picked up all the dependencies correctly. If any of > > these really need to get cherry-picked into stable kernels, cc me and > > wait for my explicit Ack. > > You can do that with the correct tag in the commit as per the stable > documentation if you really want to :) > > But why would these not be able to go backwards? What changed to > require them now and not be ok for older kernels? Depending on how far back we go in terms of kernel version, it'd be a bunch of cycle detection logic, deferred probe behavior change, etc. And those patches might have other dependencies themselves, etc. He's one example of such a breakage: https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-74d360bd3002@xxxxxxxxxxxx/ -Saravana