On Wed, Oct 23, 2024 at 12:13:36PM -0700, Saravana Kannan wrote: > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure > all its fwnode consumers are linked to it using device links: > > mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 > tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 > > Reported-by: "Nícolas F. R. A. Prado" <nfraprado@xxxxxxxxxxxxx> > Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ > Tested-by: "Nícolas F. R. A. Prado" <nfraprado@xxxxxxxxxxxxx> > Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx> > Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@xxxxxxxxxx/ Hi Saravana, the issue faced by Jon needs the exact same change but in a different place, drivers/phy/tegra/xusb.c, which I posted at: https://lore.kernel.org/all/f979aff2-34f4-4f6d-bb9a-03a02afc4635@notapiano/ So we need two separate patches, one for each issue. Feel free to add that to this series. (I could send it myself, but I think it makes more sense to keep them together) Thanks, Nícolas