Dear Morimoto-san, On Wed, Oct 23, 2024 at 04:40:45AM +0000, Kuninori Morimoto wrote: > > Hi Sakari, again > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > index 11b922fde7af..6a5d27dd0c64 100644 > > > --- a/drivers/of/property.c > > > +++ b/drivers/of/property.c > > > @@ -630,6 +630,43 @@ struct device_node *of_graph_get_port_by_id(struct device_node *parent, u32 id) > > > } > > > EXPORT_SYMBOL(of_graph_get_port_by_id); > > > > > > +/** > > > + * of_graph_get_next_port() - get next port node. > > > + * @parent: pointer to the parent device node, or parent ports node > > > + * @prev: previous port node, or NULL to get first > > > + * > > > + * Parent device node can be used as @parent whether device node has ports node or not. > > > > This line should be wrapped, no reason to have it longer than 80 chars. > > We can use 100 char now on upstream ? > > commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > ("checkpatch/coding-style: deprecate 80-column warning") It's the checkpatch.pl warning that's gone, not the preference to have lines shorter than that. This is reflected in Documentation/process/coding-style.rst as well as the commit message of the patch removing the warning. > > Thank you for your help !! You're welcome! -- Kind regards, Sakari Ailus