On Tue, Oct 22, 2024 at 11:33:35PM +0200, Jakob Hauser wrote: > The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By > introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common. > > Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx> > --- > Patch is based on current branch drm-misc-next. > --- > .../bindings/display/panel/panel-common.yaml | 8 ++++++++ > .../bindings/display/panel/samsung,s6e8aa0.yaml | 10 ++-------- > 2 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > index 0a57a31f4f3d..087415753d60 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > @@ -51,6 +51,14 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [0, 90, 180, 270] > > + flip-horizontal: > + description: boolean to flip image horizontally > + type: boolean > + > + flip-vertical: > + description: boolean to flip image vertically > + type: boolean > + I actually wonder how or why would you need to flip the images. I understand rotation, but this is mirror flip, right? Is it for some transparent displays? The change is fine, I just really wonder about hardware. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof