Hi
Am 22.10.24 um 17:36 schrieb Jon Hunter:
We'd turn a linker/modpost error into a compiler error. Likely makes
no difference. And AFAICT every driver that selects TTM also selects
TTM_HELPER. Drivers without TTM should not use this header.
Yes I also noted that all the current drivers select TTM_HELPER and so
we don't run into this. However, it still seems a bit odd that we
don't expose a proper stub if TTM_HELPER is disabled (especially
seeing as there is a stub defined).
It's not different from other headers AFAICT. For example, the TTM
headers don't guard any of their interfaces or provide stubs. The guards
and stubs only make sense if an interface really is optional wrt some
config token. That's not the case here wrt DRM_TTM_HELPER.
Best regards
Thomas
Jon
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
