On Mon, 07 Oct 2024, R Sundar <prosunofficial@xxxxxxxxx> wrote: > Use str_on_off string helpers for better readability and to fix cocci > warning. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Julia Lawall <julia.lawall@xxxxxxxx> > Closes: https://lore.kernel.org/r/202410071252.cWILJzrH-lkp@xxxxxxxxx/ > Signed-off-by: R Sundar <prosunofficial@xxxxxxxxx> Pushed to drm-intel-next, thanks for the patch. BR, Jani. > --- > > Reported in linux repo: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > cocci warnings: (new ones prefixed by >>) >>> drivers/gpu/drm/i915/display/intel_dp.c:2243:6-9: opportunity for str_on_off(dsc) > > vim +2243 drivers/gpu/drm/i915/display/intel_dp.c > > compile tested only. > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index fbb096be02ad..733619b14193 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2475,7 +2475,7 @@ intel_dp_compute_config_link_bpp_limits(struct intel_dp *intel_dp, > encoder->base.base.id, encoder->base.name, > crtc->base.base.id, crtc->base.name, > adjusted_mode->crtc_clock, > - dsc ? "on" : "off", > + str_on_off(dsc), > limits->max_lane_count, > limits->max_rate, > limits->pipe.max_bpp, -- Jani Nikula, Intel
