On Sun, Oct 20, 2024 at 09:37:41PM +1300, Ryan Walklin wrote:
> The Anbernic RG35XX devices use an SPI LCD panel from an unknown OEM,
> with an NV3052C driver chip.
>
> As discussed previously, the integrating vendor and device name are
> preferred instead of the OEM serial. A previous patch corrected the
> device tree binding and of_device_id in the NV3052C driver, however the
> spi_device_id also needs correction.
>
> Correct the spi_device_id for the RG35XX panel.
>
> Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx>
> Fixes: 76dce2a9 ("drm: panel: nv3052c: Correct WL-355608-A8 panel compatible")
I had to fix the Fixes tag when applying the patch. It is recommended to
use 12 chars of the commit id. For example in my ~/.gitconfig I have the
following part, so `git log --pretty=fixes` gives me correct Fixes
line:
[pretty]
fixes = %C(auto)commit %H%Creset%nFixes: %h (\"%s\")%nAuthor: %aN <%aE>%nDate: %aD%nComitter-Date: %cD%n%n%w(0,4,4)%b
> Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index d3baccfe6286b..06e16a7c14a75 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -917,7 +917,7 @@ static const struct nv3052c_panel_info wl_355608_a8_panel_info = {
> static const struct spi_device_id nv3052c_ids[] = {
> { "ltk035c5444t", },
> { "fs035vg158", },
> - { "wl-355608-a8", },
> + { "rg35xx-plus-panel", },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(spi, nv3052c_ids);
> --
> 2.47.0
>
--
With best wishes
Dmitry
