Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jinjie,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.12-rc3 next-20241017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/drm-connector-hdmi-Fix-memory-leak-in-drm_display_mode_from_cea_vic/20241014-152022
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20241014071632.989108-2-ruanjinjie%40huawei.com
patch subject: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()
config: arm-randconfig-002-20241017 (https://download.01.org/0day-ci/archive/20241017/202410172046.2W97YGlm-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241017/202410172046.2W97YGlm-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410172046.2W97YGlm-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/tests/drm_connector_test.c:1008:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1031:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1051:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1074:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1094:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1117:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1142:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1182:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1209:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1233:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1257:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1281:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   12 errors generated.


vim +1008 drivers/gpu/drm/tests/drm_connector_test.c

   987	
   988	/*
   989	 * Test that for a given mode, with 8bpc and an RGB output the TMDS
   990	 * character rate is equal to the mode pixel clock.
   991	 */
   992	static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
   993	{
   994		struct drm_connector_init_priv *priv = test->priv;
   995		const struct drm_display_mode *mode;
   996		unsigned long long rate;
   997		struct drm_device *drm = &priv->drm;
   998	
   999		mode = drm_display_mode_from_cea_vic(drm, 16);
  1000		KUNIT_ASSERT_NOT_NULL(test, mode);
  1001	
  1002		KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK);
  1003	
  1004		rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
  1005		KUNIT_ASSERT_GT(test, rate, 0);
  1006		KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
  1007	
> 1008		drm_mode_destroy(drm, mode);
  1009	}
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux