Hi,
On 10/16/24 12:27 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Oct 10, 2024 at 01:40:51AM +0300, Cristian Ciocaltea wrote:
>> +struct platform_driver dw_hdmi_qp_rockchip_pltfm_driver = {
>> + .probe = dw_hdmi_qp_rockchip_probe,
>> + .remove_new = dw_hdmi_qp_rockchip_remove,
>> + .driver = {
>> + .name = "dwhdmiqp-rockchip",
>> + .pm = &dw_hdmi_qp_rockchip_pm,
>> + .of_match_table = dw_hdmi_qp_rockchip_dt_ids,
>> + },
>> +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>
> Additionally I suggest to drop one of the white spaces between .probe
> and =.
Handled both in v10 [1].
Thanks,
Cristian
[1] https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@xxxxxxxxxxxxx/
