On 2024-09-16 14:23, Thomas Weißschuh wrote: > Hi Harry, Leo and other amdgpu maintainers, > > On 2024-08-24 20:33:53+0000, Thomas Weißschuh wrote: >> The value of "min_input_signal" returned from ATIF on a Framework AMD 13 >> is "12". This leads to a fairly bright minimum display backlight. >> >> Introduce a quirk to override "min_input_signal" to "0" which leads to a >> much lower minimum brightness, which is still readable even in daylight. > > could you take another look at the series? > The issues around panel power are not specific to the low pwm values, > so shouldn't have an impact on this series. > (And are nearly imperceptible anyways) > I think these patches are good. Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx> Harry >> One solution would be a fixed firmware version, which was announced but >> has no timeline. >> >> --- >> Changes in v6: >> - Clean up cover letter and commit messages >> - Add my S-o-b to patch from Dustin >> - Mention testing in combination with "panel_power_savings" >> - Link to v5: https://lore.kernel.org/r/20240818-amdgpu-min-backlight-quirk-v5-0-b6c0ead0c73d@xxxxxxxxxxxxxx >> >> Changes in v5: >> - Forward-declare struct drm_edid >> - Reorder patches, quirk entries are last >> - Add patch from Dustin for additional quirk entries >> - Link to v4: https://lore.kernel.org/r/20240812-amdgpu-min-backlight-quirk-v4-0-56a63ff897b7@xxxxxxxxxxxxxx >> >> Changes in v4: >> - Switch back to v2 implementation >> - Add MODULE_DESCRIPTION() >> - Simplify quirk infrastructure to only handle min backlight quirks. >> It can be extended if necessary. >> - Expand documentation. >> - Link to v3: https://lore.kernel.org/r/20240731-amdgpu-min-backlight-quirk-v3-0-46d40bb21a62@xxxxxxxxxxxxxx >> >> Changes in v3: >> - Switch to cmdline override parameter >> - Link to v2: https://lore.kernel.org/r/20240623-amdgpu-min-backlight-quirk-v2-0-cecf7f49da9b@xxxxxxxxxxxxxx >> >> Changes in v2: >> - Introduce proper drm backlight quirk infrastructure >> - Quirk by EDID and DMI instead of only DMI >> - Limit quirk to only single Framework 13 matte panel >> - Link to v1: https://lore.kernel.org/r/20240610-amdgpu-min-backlight-quirk-v1-1-8459895a5b2a@xxxxxxxxxxxxxx >> >> --- >> Dustin L. Howett (1): >> drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels >> >> Thomas Weißschuh (3): >> drm: Add panel backlight quirks >> drm/amd/display: Add support for minimum backlight quirk >> drm: panel-backlight-quirks: Add Framework 13 matte panel >> >> Documentation/gpu/drm-kms-helpers.rst | 3 + >> drivers/gpu/drm/Kconfig | 4 + >> drivers/gpu/drm/Makefile | 1 + >> drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++ >> drivers/gpu/drm/drm_panel_backlight_quirks.c | 94 +++++++++++++++++++++++ >> include/drm/drm_utils.h | 4 + >> 7 files changed, 117 insertions(+) >> --- >> base-commit: d2bafcf224f3911b183113b2fcb536c9e90684a3 >> change-id: 20240610-amdgpu-min-backlight-quirk-8402fd8e736a >> >> Best regards, >> -- >> Thomas Weißschuh <linux@xxxxxxxxxxxxxx> >>
