Re: [PATCH 1/2] drm/sched: adding a new scheduling policy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-exynos/exynos-drm-next]
[also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.12-rc2 next-20241011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jesse-zhang-amd-com/drm-amdgpu-add-the-ring-id-schedule-module-parameter-for-amdgpu/20241011-142247
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link:    https://lore.kernel.org/r/20241011062136.1019695-1-jesse.zhang%40amd.com
patch subject: [PATCH 1/2] drm/sched: adding a new scheduling policy
config: i386-randconfig-141-20241012 (https://download.01.org/0day-ci/archive/20241012/202410121939.cZrBIAkO-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241012/202410121939.cZrBIAkO-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410121939.cZrBIAkO-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/xe/xe_sched_job.c: In function 'xe_sched_job_arm':
>> drivers/gpu/drm/xe/xe_sched_job.c:284:9: error: too few arguments to function 'drm_sched_job_arm'
     284 |         drm_sched_job_arm(&job->drm);
         |         ^~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/xe/xe_sched_job_types.h:11,
                    from drivers/gpu/drm/xe/xe_sched_job.h:9,
                    from drivers/gpu/drm/xe/xe_sched_job.c:6:
   include/drm/gpu_scheduler.h:556:6: note: declared here
     556 | void drm_sched_job_arm(struct drm_sched_job *job, int ring);
         |      ^~~~~~~~~~~~~~~~~


vim +/drm_sched_job_arm +284 drivers/gpu/drm/xe/xe_sched_job.c

dd08ebf6c3525a Matthew Brost             2023-03-30  239  
dd08ebf6c3525a Matthew Brost             2023-03-30  240  void xe_sched_job_arm(struct xe_sched_job *job)
dd08ebf6c3525a Matthew Brost             2023-03-30  241  {
4fc4899e86f7af Thomas Hellström          2024-03-27  242  	struct xe_exec_queue *q = job->q;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  243  	struct dma_fence *fence, *prev;
4fc4899e86f7af Thomas Hellström          2024-03-27  244  	struct xe_vm *vm = q->vm;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  245  	u64 seqno = 0;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  246  	int i;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  247  
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  248  	/* Migration and kernel engines have their own locking */
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  249  	if (IS_ENABLED(CONFIG_LOCKDEP) &&
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  250  	    !(q->flags & (EXEC_QUEUE_FLAG_KERNEL | EXEC_QUEUE_FLAG_VM))) {
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  251  		lockdep_assert_held(&q->vm->lock);
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  252  		if (!xe_vm_in_lr_mode(q->vm))
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  253  			xe_vm_assert_held(q->vm);
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  254  	}
4fc4899e86f7af Thomas Hellström          2024-03-27  255  
4fc4899e86f7af Thomas Hellström          2024-03-27  256  	if (vm && !xe_sched_job_is_migration(q) && !xe_vm_in_lr_mode(vm) &&
4fc4899e86f7af Thomas Hellström          2024-03-27  257  	    (vm->batch_invalidate_tlb || vm->tlb_flush_seqno != q->tlb_flush_seqno)) {
4fc4899e86f7af Thomas Hellström          2024-03-27  258  		xe_vm_assert_held(vm);
4fc4899e86f7af Thomas Hellström          2024-03-27  259  		q->tlb_flush_seqno = vm->tlb_flush_seqno;
4fc4899e86f7af Thomas Hellström          2024-03-27  260  		job->ring_ops_flush_tlb = true;
4fc4899e86f7af Thomas Hellström          2024-03-27  261  	}
4fc4899e86f7af Thomas Hellström          2024-03-27  262  
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  263  	/* Arm the pre-allocated fences */
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  264  	for (i = 0; i < q->width; prev = fence, ++i) {
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  265  		struct dma_fence_chain *chain;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  266  
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  267  		fence = job->ptrs[i].lrc_fence;
264eecdba211bb Niranjana Vishwanathapura 2024-05-29  268  		xe_lrc_init_seqno_fence(q->lrc[i], fence);
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  269  		job->ptrs[i].lrc_fence = NULL;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  270  		if (!i) {
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  271  			job->lrc_seqno = fence->seqno;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  272  			continue;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  273  		} else {
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  274  			xe_assert(gt_to_xe(q->gt), job->lrc_seqno == fence->seqno);
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  275  		}
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  276  
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  277  		chain = job->ptrs[i - 1].chain_fence;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  278  		dma_fence_chain_init(chain, prev, fence, seqno++);
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  279  		job->ptrs[i - 1].chain_fence = NULL;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  280  		fence = &chain->base;
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  281  	}
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  282  
0ac7a2c745e8a4 Thomas Hellström          2024-05-27  283  	job->fence = fence;
dd08ebf6c3525a Matthew Brost             2023-03-30 @284  	drm_sched_job_arm(&job->drm);
dd08ebf6c3525a Matthew Brost             2023-03-30  285  }
dd08ebf6c3525a Matthew Brost             2023-03-30  286  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux