On Mon, 30 Sep 2024, shiyongbang <shiyongbang@xxxxxxxxxx> wrote:
From: baihan li <libaihan@xxxxxxxxxx>
Add dp aux read/write functions. They are basic functions
and will be used later.
You're supposed to use struct drm_dp_aux, add a .transfer function,
initialize it with intel_dp_aux_init(), and register with
intel_dp_aux_register(). Then you can use the standard drm_dp_dpcd_*
calls to access aux. They handle a lot of the boilerplate for DP
aux. You'll also get the i2c and aux device nodes for free. As well as a
lot of helpers based on struct drm_dp_aux interface.
There's a lot of duplication in this patch otherwise too. The DPCD
register macros, a dupe for struct drm_dp_aux_msg, etc.
BR,
Jani.
Hi Jani,
Thanks for your advice. I didn't notice that the drm framework
has this implementation, and I'll use the struct drm_dp_aux and
drm_dp_aux_init() function in the next version to simplify my code.
And I will check if there are others implementation in drm_dp_helper.c.
Baihan Li.
