On Thu, Oct 10, 2024 at 12:46:34AM -0600, Everest K.C. wrote: > The pointer list->list is dereferenced before the NULL check. > Fix this by moving the NULL check outside the for loop, so that > the check is performed before the dereferencing. > The list->list pointer cannot be NULL so this has no effect on runtime. > It's just a correctness issue. > > This issue was reported by Coverity Scan. > https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600335 > > Fixes: a18c696fa5cb ("drm/xe/guc: Fix dereference before Null check") > Signed-off-by: Everest K.C. <everestkc@xxxxxxxxxxxxxxxx> > --- Perfect! Thanks. Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter
