On Tue, 8 Oct 2024 at 01:04, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Mon, Oct 7, 2024 at 1:14 PM Aleksandrs Vinarskis > <alex.vinarskis@xxxxxxxxx> wrote: > > > > Introduce low-res IPS and OLED panels for mentioned device. > > > > SHP panel's timings were picked experimentally, without this patch or with > > `delay_200_500_e50` panel sometimes fails to boot/stays black on startup. > > > > LGD panel's timings were copied from other LGD panels and tested to be > > working. > > > > Particular laptop also comes in high-res IPS variant, which unfortunately > > I do not have access to verify. > > > > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx> > > Tested-by: Peter de Kraker <peterdekraker@xxxxxxxx> > > Your signed-off-by should be _below_ Peter's Tested-by. That means > that you're the one that signed-off on the fact that Peter tested > this. > Got it. I thought the author's signoff (me) would always be first. > > --- > > drivers/gpu/drm/panel/panel-edp.c | 2 ++ > > 1 file changed, 2 insertions(+) > > This looks OK to me. I've been requesting people include the RAW EDID > of panels that they add in the commit message, though. Could you do > that and send a v2? Probably missed that requirement, my bad, will respin. > Also: note that since I didn't see Peter provide > his Tested-by himself, I'd probably wait a little longer before > landing to give him a chance to object. I'll drop his test-by, and he can mail in himself directly then. Thanks for the review Alex > > -Doug
