Re: [PATCH v6 21/44] drm/vkms: Add tests for CTM handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Harry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.12-rc1 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Harry-Wentland/drm-Add-helper-for-conversion-from-signed-magnitude/20241004-040629
base:   git://anongit.freedesktop.org/drm/drm drm-next
patch link:    https://lore.kernel.org/r/20241003200129.1732122-22-harry.wentland%40amd.com
patch subject: [PATCH v6 21/44] drm/vkms: Add tests for CTM handling
config: csky-randconfig-r112-20241005 (https://download.01.org/0day-ci/archive/20241005/202410051850.cGJoBKkg-lkp@xxxxxxxxx/config)
compiler: csky-linux-gcc (GCC) 14.1.0
reproduce: (https://download.01.org/0day-ci/archive/20241005/202410051850.cGJoBKkg-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051850.cGJoBKkg-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
   drivers/gpu/drm/vkms/tests/vkms_color_test.c:34:29: sparse: sparse: symbol 'test_linear_lut' was not declared. Should it be static?
>> drivers/gpu/drm/vkms/tests/vkms_color_test.c:193:32: sparse: sparse: symbol 'test_matrix_3x4_50_desat' was not declared. Should it be static?
>> drivers/gpu/drm/vkms/tests/vkms_color_test.c:259:32: sparse: sparse: symbol 'test_matrix_3x4_bt709_enc' was not declared. Should it be static?

vim +/test_matrix_3x4_50_desat +193 drivers/gpu/drm/vkms/tests/vkms_color_test.c

   192	
 > 193	const struct drm_color_ctm_3x4 test_matrix_3x4_50_desat = { {
   194		FIXPT_HALF, FIXPT_QUARTER, FIXPT_QUARTER, 0,
   195		FIXPT_QUARTER, FIXPT_HALF, FIXPT_QUARTER, 0,
   196		FIXPT_QUARTER, FIXPT_QUARTER, FIXPT_HALF, 0
   197	} };
   198	
   199	static void vkms_color_ctm_3x4_50_desat(struct kunit *test)
   200	{
   201		struct pixel_argb_s32 ref, out;
   202	
   203		/* full white */
   204		ref.a = 0xffff;
   205		ref.r = 0xffff;
   206		ref.g = 0xffff;
   207		ref.b = 0xffff;
   208	
   209		memcpy(&out, &ref, sizeof(out));
   210		apply_3x4_matrix(&out, &test_matrix_3x4_50_desat);
   211	
   212		KUNIT_EXPECT_MEMEQ(test, &ref, &out, sizeof(out));
   213	
   214		/* full black */
   215		ref.a = 0xffff;
   216		ref.r = 0x0;
   217		ref.g = 0x0;
   218		ref.b = 0x0;
   219	
   220		memcpy(&out, &ref, sizeof(out));
   221		apply_3x4_matrix(&out, &test_matrix_3x4_50_desat);
   222	
   223		KUNIT_EXPECT_MEMEQ(test, &ref, &out, sizeof(out));
   224	
   225		/* 50% grey */
   226		ref.a = 0xffff;
   227		ref.r = 0x8000;
   228		ref.g = 0x8000;
   229		ref.b = 0x8000;
   230	
   231		memcpy(&out, &ref, sizeof(out));
   232		apply_3x4_matrix(&out, &test_matrix_3x4_50_desat);
   233	
   234		KUNIT_EXPECT_MEMEQ(test, &ref, &out, sizeof(out));
   235	
   236		/* full red to 50% desat */
   237		ref.a = 0xffff;
   238		ref.r = 0x8000;
   239		ref.g = 0x4000;
   240		ref.b = 0x4000;
   241	
   242		out.a = 0xffff;
   243		out.r = 0xffff;
   244		out.g = 0x0;
   245		out.b = 0x0;
   246	
   247		apply_3x4_matrix(&out, &test_matrix_3x4_50_desat);
   248	
   249		KUNIT_EXPECT_MEMEQ(test, &ref, &out, sizeof(out));
   250	}
   251	
   252	/*
   253	 * BT.709 encoding matrix
   254	 *
   255	 * Values printed from within IGT when converting
   256	 * igt_matrix_3x4_bt709_enc to the fixed-point format expected
   257	 * by DRM/KMS.
   258	 */
 > 259	const struct drm_color_ctm_3x4 test_matrix_3x4_bt709_enc = { {
   260		0x00000000366cf400ull, 0x00000000b7175900ull, 0x0000000127bb300ull, 0,
   261		0x800000001993b3a0ull, 0x800000005609fe80ull, 0x000000006f9db200ull, 0,
   262		0x000000009d70a400ull, 0x800000008f011100ull, 0x800000000e6f9330ull, 0
   263	} };
   264	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux