On Mon, 30 Sep 2024, Lyude Paul <lyude@xxxxxxxxxx> wrote: > diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h > index b2e05f8c2ee7d..04898f70ef1b8 100644 > --- a/rust/bindings/bindings_helper.h > +++ b/rust/bindings/bindings_helper.h > @@ -9,6 +9,7 @@ > #include <drm/drm_device.h> > #include <drm/drm_drv.h> > #include <drm/drm_file.h> > +#include <drm/drm_fourcc.h> > #include <drm/drm_gem.h> > #include <drm/drm_gem_shmem_helper.h> > #include <drm/drm_ioctl.h> Unrelated to the patch, sorry, but... what's the idea with putting all the bindings in the same file? Does it mean every time any of the files or their dependencies get changed, *all* the rust bindings get regenerated? Should there be more granularity? BR, Jani. -- Jani Nikula, Intel
