Hi Liu, > -----Original Message----- > From: Liu Ying <victor.liu@xxxxxxx> > Sent: Monday, September 30, 2024 10:40 AM > Subject: Re: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter > > On 09/30/2024, Biju Das wrote: > > Hi Liu, > > Hi Biju, > > > > > Thanks for the patch. > > > >> -----Original Message----- > >> From: linux-arm-kernel <linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx> > >> On Behalf Of Liu Ying > >> Sent: Monday, September 30, 2024 6:29 AM > >> Subject: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI > >> converter > >> > >> Add basic HDMI video output support. Currently, only RGB888 output > >> pixel format is supported. At the LVDS input side, the driver > >> supports single LVDS link and dual LVDS links with "jeida-24" LVDS mapping. > >> > >> Product link: > >> https://www.ite.com.tw/en/product/cate1/IT6263 > >> > >> Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > >> --- > >> drivers/gpu/drm/bridge/Kconfig | 8 + > >> drivers/gpu/drm/bridge/Makefile | 1 + > >> drivers/gpu/drm/bridge/ite-it6263.c | 829 > >> ++++++++++++++++++++++++++++ > >> 3 files changed, 838 insertions(+) > >> create mode 100644 drivers/gpu/drm/bridge/ite-it6263.c > >> > >> diff --git a/drivers/gpu/drm/bridge/Kconfig > >> + > >> + it->lvds_i2c = devm_i2c_new_dummy_device(dev, client->adapter, > >> + LVDS_INPUT_CTRL_I2C_ADDR); > >> + if (IS_ERR(it->lvds_i2c)) > >> + dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c), > >> + "failed to allocate I2C device for LVDS\n"); > > > > Maybe use action_or_reset and call i2c_unregister_device(); > > devm_i2c_new_dummy_device() is called here. It is a dev managed function call. Action > devm_i2c_release_dummy() is added in it already. Oops. I missed that. Cheers, Biju
