>-----Original Message-----
>From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>Sent: Thursday, September 26, 2024 8:58 PM
>To: Hermes Wu (吳佳宏) <Hermes.Wu@xxxxxxxxxx>
>Cc: Kenneth Hung (洪家倫) <Kenneth.Hung@xxxxxxxxxx>; Andrzej Hajda <andrzej.hajda@xxxxxxxxx>; Neil Armstrong <neil.armstrong@xxxxxxxxxx>; Robert Foss <rfoss@xxxxxxxxxx>; Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>; Jonas Karlman <jonas@xxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx>; Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter <simona@xxxxxxxx>; AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>; Allen Chen <allen.chen@xxxxxxxxxx>; open list:DRM DRIVERS <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
>Subject: Re: [PATCH v4 11/11] drm/bridge: it6505: Add aux i2c functionality
>
>On Thu, Sep 26, 2024 at 03:51:34PM GMT, Hermes Wu wrote:
>> From: Hermes Wu <Hermes.wu@xxxxxxxxxx>
>>
>> Add aux-i2c operaction in order to support the MCCS function.
>
>Brevity is the soul of wit. However in the commit message we appreciate more details. Is it enough to get monitor control to work? Or is there anything left to be implemented?
In drm_dp_helper, drm_dp_i2c_xfer() pack I2C request into sequence of AUX request.
it6505_aux_i2c_operation() is implement to match drm_dp_i2c_xfer() behavior
>>
>>
>> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
>
>This is definitely not a fix.
will remove.
>> Signed-off-by: Hermes Wu <Hermes.wu@xxxxxxxxxx>
>> ---
>> drivers/gpu/drm/bridge/ite-it6505.c | 177
>> +++++++++++++++++++++++++++-
>> 1 file changed, 175 insertions(+), 2 deletions(-)
>
>--
>With best wishes
>Dmitry
>
BR,
Hermes
