> > -static void edid_block_status_print(enum edid_block_status status,
> > +static void edid_block_status_print(struct drm_connector *connector,
> > + enum edid_block_status status,
> > const struct edid *block,
> > int block_num)
> > {
> > + if (status != EDID_BLOCK_OK &&
> > + connector &&
> > + !connector->bad_edid_counter++ &&
>
> The status print has no business changing anything. Besides, this
> function gets called per EDID block, not per EDID.
In this case it doesn't matter because the counter only
prints once per life time of a connector structure,
or if it wraps.
I suppose this can be moved into a wrapper.
>
> > + !drm_debug_enabled(DRM_UT_KMS))
>
> If we did that, we might just as well change the pr_* prints to
> drm_dbg_kms() and be done with it.
But that would prevent it always unless debug is set?
I was trying to print it according to counter first. This matches
the existing usage.
-Andi
