Re: [PATCH v5 47/80] drm/xlnx: Run DRM default client setup

[Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>]

On 24/09/2024 10:12, Thomas Zimmermann wrote:
> Call drm_client_setup_with_fourcc() to run the kernel's default client
> setup for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> v5:
> - select DRM_CLIENT_SELECTION
> v2:
> - use drm_client_setup_with_fourcc()
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> Cc: Michal Simek <michal.simek@xxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
>   drivers/gpu/drm/xlnx/Kconfig      | 1 +
>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++-
>   2 files changed, 4 insertions(+), 1 deletion(-)

Tested on zynqmp zcu106.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

 Tomi

> diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig
> index 626e5ac4c33d..4197f44e202f 100644
> --- a/drivers/gpu/drm/xlnx/Kconfig
> +++ b/drivers/gpu/drm/xlnx/Kconfig
> @@ -6,6 +6,7 @@ config DRM_ZYNQMP_DPSUB
>   	depends on PHY_XILINX_ZYNQMP
>   	depends on XILINX_ZYNQMP_DPDMA
>   	select DMA_ENGINE
> +	select DRM_CLIENT_SELECTION
>   	select DRM_DISPLAY_DP_HELPER
>   	select DRM_DISPLAY_HELPER
>   	select DRM_BRIDGE_CONNECTOR
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index bd1368df7870..2452c2f09161 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -14,6 +14,7 @@
>   #include <drm/drm_blend.h>
>   #include <drm/drm_bridge.h>
>   #include <drm/drm_bridge_connector.h>
> +#include <drm/drm_client_setup.h>
>   #include <drm/drm_connector.h>
>   #include <drm/drm_crtc.h>
>   #include <drm/drm_device.h>
> @@ -402,6 +403,7 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = {
>   					  DRIVER_ATOMIC,
>   
>   	DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
> +	DRM_FBDEV_DMA_DRIVER_OPS,
>   
>   	.fops				= &zynqmp_dpsub_drm_fops,
>   
> @@ -523,7 +525,7 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
>   		goto err_poll_fini;
>   
>   	/* Initialize fbdev generic emulation. */
> -	drm_fbdev_dma_setup(drm, 24);
> +	drm_client_setup_with_fourcc(drm, DRM_FORMAT_RGB888);
>   
>   	return 0;
>