Re: [PATCH] [V2] drm: panel-orientation-quirks: Also handle rotation for DeckHD equipped LCDs units

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 01, 2024 at 09:10:03AM GMT, Marco Rodolfi wrote:
> From: Marco Rodolfi <marco.rodolfi@xxxxxxx>
> 
> This patch also take account of the different resolution for the
> aftermarket DeckHD panel, which hasn't been accounted for yet in kernel,
> since these quirks are applied based on BIOS information + panel
> resolution.
> 
> This patch correct that problem and make the panel oriented the right
> way.

Please improve the commit message (see
Documentation/process/submitting-patches.rst).

For example:

Orientation quirk code take panel resolution into account when
determining panel orientation. Add orientation configuration for the
popular aftermarket DeckHD panel, which resolution (1200x1920) differs
from the standard panel (800x1280).

> 
> Changes in V2:
> Had some issues with gmail and this mailinglist that I completely
> mistyped the panel resolution in the original patch. It is still a 16:10
> panel, not a 16:9, so the original one is wrong. It's fixed now.
> 
> Signed-off-by: Marco Rodolfi <marco.rodolfi@xxxxxxx>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3860a8ce1e2d..32582dbdc184 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -420,13 +420,20 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galaxy Book 10.6"),
>  		},
>  		.driver_data = (void *)&lcd1280x1920_rightside_up,
> -	}, {	/* Valve Steam Deck (Jupiter) */
> +	}, {	/* Valve Steam Deck (Jupiter) Stock Display */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>  		},
>  		.driver_data = (void *)&lcd800x1280_rightside_up,
> +	}, {	/* Valve Steam Deck (Jupiter) DeckHD Display */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> +		},
> +		.driver_data = (void *)&lcd1200x1920_rightside_up,
>  	}, {	/* Valve Steam Deck (Galileo) */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> -- 
> 2.46.0
> 

-- 
With best wishes
Dmitry



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux