RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >> > +static __inline__ void set_bin_index_0(struct intel_display
> >> > +*display, enum pipe pipe)
> >>           ^^^^^^^^^^
> >>
> >> Why?
> >>
> > Sorry, didn't get your question. Is it why "enum pipe pipe"
> 
> No, why __inline__? What's the point?
> 
> (I tried to underline it with ^^^^^^^^^^ [1].)
> 
> You should basically never use inline in .c files, just let the compiler do its job.
> And if you do need to use inline in headers, it should be "inline", not
> "__inline__". See include/linux/compiler_types.h.
> 
The code within the inline functions is very much small and in order to execute
that small code with functions involve register usage, hence thought of using
inline.
Will remove inline!

Thanks and Regards,
Arun R Murthy
--------------------




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux